Skip to content

Comments

GH-45992: [C++] Bump bundled utf8proc version to 2.10.0#46032

Merged
kou merged 1 commit intoapache:mainfrom
raulcd:GH-45992
Apr 5, 2025
Merged

GH-45992: [C++] Bump bundled utf8proc version to 2.10.0#46032
kou merged 1 commit intoapache:mainfrom
raulcd:GH-45992

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Apr 4, 2025

Rationale for this change

The version we are currently using is pretty old, from 2021.

What changes are included in this PR?

Bump the version to latest 2.10.0:
https://github.com/JuliaStrings/utf8proc/releases/tag/v2.10.0

Also remove the requirement to use -DCMAKE_POLICY_VERSION_MINIMUM when building it as 2.10 cmake_minimum_required version is 3.10 (previously was 3.0)

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

⚠️ GitHub issue #45992 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Apr 4, 2025

@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled test-ubuntu-24.04-cpp-bundled-offline

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Revision: 062bfab

Submitted crossbow builds: ursacomputing/crossbow @ actions-bda1acbfb4

Task Status
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions

@raulcd raulcd requested review from assignUser and kou April 4, 2025 15:13
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit cc0606f into apache:main Apr 5, 2025
33 of 34 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Apr 5, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 5, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cc0606f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

lriggs pushed a commit to lriggs/arrow that referenced this pull request Apr 15, 2025
…#46032)

The version we are currently using is pretty old, from 2021.

Bump the version to latest 2.10.0:
https://github.com/JuliaStrings/utf8proc/releases/tag/v2.10.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it as 2.10 `cmake_minimum_required` version is `3.10` (previously was `3.0`)

Yes via CI

No

* GitHub Issue: apache#45992

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs pushed a commit to lriggs/arrow that referenced this pull request Apr 15, 2025
…#46032)

The version we are currently using is pretty old, from 2021.

Bump the version to latest 2.10.0:
https://github.com/JuliaStrings/utf8proc/releases/tag/v2.10.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it as 2.10 `cmake_minimum_required` version is `3.10` (previously was `3.0`)

Yes via CI

No

* GitHub Issue: apache#45992

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Apr 15, 2025
…#46032)

### Rationale for this change

The version we are currently using is pretty old, from 2021.

### What changes are included in this PR?

Bump the version to latest 2.10.0:
https://github.com/JuliaStrings/utf8proc/releases/tag/v2.10.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it as 2.10 `cmake_minimum_required` version is `3.10` (previously was `3.0`)

### Are these changes tested?

Yes via CI 

### Are there any user-facing changes?

No

* GitHub Issue: apache#45992

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants